fix(tui): log debug file errors#1317
Closed
resolvicomai wants to merge 3 commits into
Closed
Conversation
floatpanebot
previously requested changes
May 21, 2026
Member
floatpanebot
left a comment
floatpanebot
left a comment
There was a problem hiding this comment.
Hi @resolvicomai! Please fix the following issues with your PR:
- Body: Missing the
## What?or## Why?headings required by the PR template.
resolvicomai
changed the title
floatpanebot
dismissed
their stale review
Formatting issues have been resolved. Thank you!
FromSi
requested changes
May 21, 2026
floatpanebot
added
area/fetcher
andrinoff
requested changes
May 21, 2026
Member
andrinoff
left a comment
andrinoff
left a comment
There was a problem hiding this comment.
@resolvicomai we are migrating to a new log introduced in #1311. Please use loglevels internal package
Contributor
Author
|
Thanks. I pushed a follow-up that routes both debug-log paths through the internal
Validation:
|
FromSi
approved these changes
May 21, 2026
andrinoff
approved these changes
May 22, 2026
Member
|
conflicts @resolvicomai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #698
Closes #699
Why?
The Kitty/image protocol debugger previously ignored both WriteString and Close errors when writing debug logs, which could hide failed diagnostics and resource cleanup problems.
Tests